Committed: change to DruidGhost.uc

This one I just added a:

if(bAlreadyPrevented) return false;

sequence. Basically, if bAlreadyPrevented, Ghost don't need to run. I even pointed this omission out to Mysterial because it's not in his either. He said thanks (and then preceeded to say that putting skills in a set order wasn't worth the trouble because you could easily end up with a circular dependency in future skills - I don't know if I agree, but that's another discussion).

I would be surprised if you guys thought we should have discussed this one.

Why return false?

As per my other comments on this issue, once bAlreadyPrevented is true (or some Ability.PD returns true), it will always be true (because of the design of Mysterial's RPGRules.PD that calls Ability.PD). However, you'd return false after this case because this Ability.PD is not the one preventing the death. In the grand scheme, it doesn't matter ... but syntactically, I think false is more correct.

Seems sensible enough to me. I don't know how often Ghost finds death has already been prevented, but I agree with you it should check.

I would be willing to bet a bit that it's "never" right now. But if it's decided that, rather than controlling the Ability order, we simply recode the other abilities to check and run Ghost manually, those manual runs would result in a "return true;" and then when Ghost is then run by RPGRules as part of it's normal loop, it will find bAlreadyPrevented is true and not do anything.

So yeah: it should check, and in the future it might be an issue to where it *has* to check.