Lucky shield spawning

Reguarding the post from tgroombr:http://www.disastrousconsequences.com/dcforum/posts/list/30/4390.page#40260

RW_Luck.ChoosePickupClass() will test if the players shield is less than max, if so add a shield pickup to the Potentials list.

The problem is that the shield pickup doesn't do anything to bring the players shield up to the max. The shield will spawn just as much as the adrenaline pickup if the player doesn't need ammo or health.

A potential fix would be to change this line:
Code:

if (Instigator.ShieldStrength < Instigator.GetShieldStrengthMax())
 			Potentials[i++] = class'ShieldPack';

to this:
Code:

 if (Instigator.ShieldStrength < 50)
 			Potentials[i++] = class'ShieldPack';

This would require subclassing the function into RW_EnhancedLuck.

Do you want to post up a patched version of the current source for this? I'll commit it if you do.

Yep, sensible idea.

Alternatively, you could just make a new armor pickup that the Lucky weapon would spawn, something like an armor shard (See: Chaos Mod). With a new pickup you could ignore the UT2004 cap on armor gained from small armors.

Something I noticed on this subject. Lucky shield spawns stack in VCTF or ONS maps (cant remember which or if it would be both). I don't know what is different in these maps that causes this, but maybe a bit of research will explain and could be implemented on the rest.

Could change it so if your current shield strength is less than 50, then it spawns a small shield, but if your current shield is 50 or more, then it spawns a super shield.

Yes I have noticed that with the lucky weapons... once i doubled my lucky flack seven and since i was full on everything thinking it would spawn me a double damage with a lucky 14, because with a lucky 14 the spawns do come extremely faster but all i got was extremely fast 50 shield packs lol, like every 2-3 sec or so

Wail wrote:

Yep, sensible idea.

Alternatively, you could just make a new armor pickup that the Lucky weapon would spawn, something like an armor shard (See: Chaos Mod). With a new pickup you could ignore the UT2004 cap on armor gained from small armors.

I like this idea. If you don't want to import/add a new mesh, spawn tiny shields or add a skin that recolors health vials.

Also another bug Ive noticed... should vehicles and turrets be susceptible to poison attacks... because simple pupae with one bite take over 300 of my turrets health and over 450 of my vehicles health

ooops posted this on the wrong subject

TheDruidXpawX wrote:

Do you want to post up a patched version of the current source for this? I'll commit it if you do.

I don't have a RPG server setup to test this with. I can set one up if you need it tested before committing.

Also: Why are there no misfortune weps?

Szlat wrote:

Could change it so if your current shield strength is less than 50, then it spawns a small shield, but if your current shield is 50 or more, then it spawns a super shield.

This would take away from the engineers.
Jefe's idea sounds neat. Make yellow vials that add small amounts of shield.